Re: iconv.m4: provide useful am_func_iconv 'no' string

[Simon Josefsson]

Bruno Haible <bruno@clisp.org> writes:

>> I can't find any uses of am_func_iconv in any M4 files in gnulib, so I'm
>> hoping that nobody is testing it for == 'no' strings but only uses !=
>> 'yes' comparisons.
>
> It's too dangerous to change the value of this variable. This macro is
> in the wild for more than 20 years. There are surely packages that use
> this variable, although it's undocumented. (E.g. GnuPG.)
>
> Let me introduce a variable 'am_func_iconv_summary'. Meant to be used
> with
>    echo "iconv:    $am_func_iconv_summary"
> Not 'libiconv', since that just the implementation. 'iconv' is the POSIX
> facility's name.

Wonderful, thank you!

/Simon

>
> 2022-07-10  Bruno Haible  <bruno@clisp.org>
>
>       iconv: Define a summary result.
>       Reported by Simon Josefsson in
>       <https://lists.gnu.org/archive/html/bug-gnulib/2022-07/msg00020.html>.
>       * m4/iconv.m4 (AM_ICONV): Define also am_cv_func_iconv_summary.
>
> diff --git a/m4/iconv.m4 b/m4/iconv.m4
> index 6f1ae2b13d..2065c9772a 100644
> --- a/m4/iconv.m4
> +++ b/m4/iconv.m4
> @@ -1,4 +1,4 @@
> -# iconv.m4 serial 25
> +# iconv.m4 serial 26
>  dnl Copyright (C) 2000-2002, 2007-2014, 2016-2022 Free Software Foundation,
>  dnl Inc.
>  dnl This file is free software; the Free Software Foundation
> @@ -274,4 +274,20 @@ size_t iconv (iconv_t cd, char * *inbuf, size_t 
> *inbytesleft, char * *outbuf, si
>         ICONV_CONST="const"
>       fi
>      ])
> +
> +  dnl A summary result, for those packages which want to print a summary at 
> the
> +  dnl end of the configuration.
> +  if test "$am_func_iconv" = yes; then
> +    if test -n "$LIBICONV"; then
> +      am_cv_func_iconv_summary='yes, in libiconv'
> +    else
> +      am_cv_func_iconv_summary='yes, in libc'
> +    fi
> +  else
> +    if test "$am_cv_func_iconv" = yes; then
> +      am_cv_func_iconv_summary='not working, consider installing GNU 
> libiconv'
> +    else
> +      am_cv_func_iconv_summary='no, consider installing GNU libiconv'
> +    fi
> +  fi
>  ])
>
>
>
>
>

signature.asc
Description: PGP signature