Re: [PATCH 2/2] error: merge from glibc and with verror

[Bruno Haible]

Paul Eggert wrote:
> Thanks, I attempted to fix that by installing the attached.

Thanks; I confirm it fixes the issue.

> I wish I didn't have to remember the 
> complicated rules for declaring Gnulib functions, and to some extent 
> this simplistic patch is a perhaps-vain attempt to cut down on that 
> complexity.

Declaring Gnulib functions in general is just a matter of copying the
same idiom that we have in hundreds of places in *.in.h files. Its
history and genesis is not simple; but the result is simple to apply.

What I find to be an unusual complexity here is that verror and verror_at_line
are defined by error.c; yet when I glance through error.c quickly I don't see
verror and verror_at_line being defined there. Hiding function definitions
behind macros...

Is it planned that glibc exports verror and verror_at_line at some point?

Also, since this was a breaking change, someone will need to send patches
to coreutils, m4, man-db, patch, and libpipeline [1]. It is not nice if
we leave it as a bad surprise to the maintainer of one of these packages.

Bruno

[1] https://codesearch.debian.net/search?q=include+%22verror.h%22&literal=1