bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

pty: Define 'struct winsize' on all platforms.


From: Collin Funk
Subject: pty: Define 'struct winsize' on all platforms.
Date: Fri, 16 Aug 2024 21:29:47 -0700
User-agent: Gnus/5.13 (Gnus v5.13)

Since termios.h defines 'struct winsize' on all platforms I think that
pty.h should also do the same. I've committed a patch doing that and
adding a basic C check program for types.

BTW, I think this fixes a very minor bug. Since the 'pty' module does
not directly depend on 'termios' but pty.in.h unconditionally includes
termios.h it would fail on Windows, for example. Very minor since I
think 'forkpty' and 'openpty' would import both header modules. Instead
of depending on only 'pty' directly.

Collin

Attachment: 0001-pty-Define-struct-winsize-on-all-platforms.patch
Description: Text Data

Attachment: 0002-pty-tests-Add-C-tests.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]