bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: coreutils 9.5 problem cross-compiling using uClibc-ng


From: Collin Funk
Subject: Re: coreutils 9.5 problem cross-compiling using uClibc-ng
Date: Wed, 21 Aug 2024 17:57:55 -0700
User-agent: Gnus/5.13 (Gnus v5.13)

Waldemar Brodkorb <wbx@openadk.org> writes:

> Would be following trivial patch acceptable, which fixes the issue for me?
>
> diff --git a/lib/mcel.h b/lib/mcel.h
> index 7d92d24601..d000bfeb5d 100644
> --- a/lib/mcel.h
> +++ b/lib/mcel.h
> @@ -226,7 +226,7 @@ mcel_scan (char const *p, char const *lim)
>  
>    /* An initial mbstate_t; initialization optimized for some platforms.
>       For details about these and other platforms, see wchar.in.h.  */
> -#if defined __GLIBC__ && 2 < __GLIBC__ + (2 <= __GLIBC_MINOR__)
> +#if defined __GLIBC__ && 2 < __GLIBC__ + (2 <= __GLIBC_MINOR__) && !defined 
> __UCLIBC__
>    /* Although only a trivial optimization, it's worth it for GNU.  */
>    mbstate_t mbs; mbs.__count = 0;
>  #elif (defined __FreeBSD__ || defined __DragonFly__ || defined __OpenBSD__ \
>
> Thanks in advance for any answer.

Bruno, can mbszero be used here instead of duplicating the #if
conditions? Isn't it achieving the same thing?

Assuming that it will be inlined and:

    memset (&mbs, 0, 4);

performs the same as:

   mbs.__count = 0;

Collin



reply via email to

[Prev in Thread] Current Thread [Next in Thread]