[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: getusershell: Don't completely ignore lines that contain a comment
From: |
Collin Funk |
Subject: |
Re: getusershell: Don't completely ignore lines that contain a comment |
Date: |
Tue, 27 Aug 2024 14:21:19 -0700 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Hi Bruno,
Bruno Haible <bruno@clisp.org> writes:
> clang on native Windows gives me this warning:
>
> gllib\getusershell.c(115,25): warning: expression which evaluates to zero
> treated as a null pointer constant of type 'char *'
> [-Wnon-literal-null-conversion]
>
> This patch fixes it. Collin, please consider strengthening the unit test.
Thanks.
I'll give the module and it's test another look over.
But it is hard to improve the test because it reads /etc/shell.
I can't modify that to check for unexpected/edge cases. :(
Collin