Re: getusershell: Don't completely ignore lines that contain a comment

[Collin Funk]

Bruno Haible <bruno@clisp.org> writes:

> I bet that most implementations read this file via open() or fopen(), right?
>
> Then how about adding to the test an open() and an fopen() function that,
> instead of opening /etc/shells, opens a data file in gnulib's tests/
> (or gltests/) directory?
>
> You know that a function in the main executable overrides the function
> in the libc, at least on ELF platforms. We thus might have to skip
> the test on macOS, maybe...

Ah, good idea thanks! It looks like the macOS version is just pulled
from 4.4BSD. If my memory is correct it looks pretty identical to the
one in glibc and some current BSDs [1].

So missing tests there wouldn't be the end of the world. I'll have a
look at improving that.

Collin

[1] https://github.com/apple-oss-distributions/Libc/blob/main/gen/getusershell.c