[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Include mini-mpq
From: |
Bruno Haible |
Subject: |
Re: Include mini-mpq |
Date: |
Wed, 28 Aug 2024 14:21:17 +0200 |
Marc Nieper-Wißkirchen wrote:
> PS Here is a suggestion for a new `mpq' module. What do you think?
Thanks for the suggestion.
I agree that it would be useful to import mini-mpq.[hc] into gnulib,
from the location that you mentioned. To do that, please augment the
file config/srclist.txt, so that we don't miss future updates.
I also agree that there should be two modules: one for mpn and mpz,
and another module for mpq, because there are many use-cases that need
only mpn and mpz.
But I don't agree with the naming of the modules. Since GMP includes
all three (mpn, mpz, mpq) in one library, the Gnulib module 'libgmp'
should do the same. This means, the existing libgmp module should be
renamed to 'libgmp-mpz', and the 'libgmp' module should then depend
on 'libgmp-mpz' and add the mini-mpq.[hc] code.
And the test source files should be renamed to
tests/test-libgmp-mpz.c
and
tests/test-libgmp-mpq.c
respectively.
Let me start with the renamings of what is already in gnulib. Then,
your additions are welcome (as two patches, please: one for the
new code in module libgmp, and one for the new tests).
2024-08-28 Bruno Haible <bruno@clisp.org>
libgmp-mpz: New module, renamed from libgmp.
* modules/libgmp-mpz: Renamed from modules/libgmp.
* modules/libgmp: New file.
* modules/libgmp-mpz-tests: Renamed from modules/libgmp-tests.
* tests/test-libgmp-mpz.c: Renamed from tests/test-libgmp.c.
https://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=9f961994f66bc50c9537912d16a7d63e85e185cb