[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] libgmp-mpq: New module.
From: |
Bruno Haible |
Subject: |
Re: [PATCH 1/2] libgmp-mpq: New module. |
Date: |
Thu, 29 Aug 2024 11:31:29 +0200 |
Hi Marc,
this looks good, except for two small things:
1) In the ChangeLog entry
> + * lib/mini-mpq.c: New upstream source file.
> + * lib/mini-mpq.h: New upstream source file.
I would like to see more precision about where "upstream" is.
Ideally, the URL that can be downloaded with 'wget'.
2) In the module description
> diff --git a/modules/libgmp-mpq b/modules/libgmp-mpq
> new file mode 100644
> index 0000000000..ac61b01bc2
> --- /dev/null
> +++ b/modules/libgmp-mpq
> @@ -0,0 +1,33 @@
> +Description:
> +GNU Multiple Precision Arithmetic library (mpq_* part),
> +or its mini-gmp substitute
The last line should be "or its mini-mpq substitute", right?
Bruno