bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] timegm: ignore incoming tm_isdst


From: Paul Eggert
Subject: Re: [PATCH 2/2] timegm: ignore incoming tm_isdst
Date: Sat, 5 Oct 2024 09:03:58 -0700
User-agent: Mozilla Thunderbird

On 2024-10-04 13:42, Bruno Haible wrote:
All existing unit tests succeed. But would it not produce more correct
results in general to set this to 1 instead of 0? That is, if we are
in the mktime()/localtime() pair, if we know nothing about the time zone,
assume that is has DST?

Thanks, good catch. I installed the attached.

POSIX says 'daylight' is an X/Open extension to POSIX, so FreeBSD is still conforming to POSIX here. Normally I'd expect FreeBSD to support XSI too, but the 'daylight' and 'timezone' variables are so useless that I guess they drew the line.

Attachment: 0001-mktime-fix-daylight-default.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]