Re: [PATCH 2/2] file-has-acl: no need for struct stat

[Bruno Haible]

Paul Eggert wrote:
> +   FLAGS should be a <dirent.h> d_type value, optionally ORed with
> +   AT_SYMLINK_FOLLOW; if the d_type value is not known,

This comment got me considering whether that's portable, and it is not:

           AT_SYMLINK_FOLLOW   DT_*

glibc/Linux    0x400           0 .. 14
musl libc      0x400           0 .. 14
Android        0x400           0 .. 14
macOS          0x400           0 .. 14
FreeBSD        0x400           0 .. 14
NetBSD         0x400           0 .. 14
OpenBSD            4           0 .. 12
AIX                2           --
Solaris       0x2000           --
Minix          0x400           0 .. 14
Cygwin             4           0 .. 14

Fortunately, it's only a typo.


2024-10-07  Bruno Haible  <bruno@clisp.org>

        file-has-acl: Fix comments.
        * lib/file-has-acl.c (file_has_aclinfo): Fix typo in comment.

diff --git a/lib/file-has-acl.c b/lib/file-has-acl.c
index 9f4213702f..1fc54a7687 100644
--- a/lib/file-has-acl.c
+++ b/lib/file-has-acl.c
@@ -328,9 +328,9 @@ acl_nfs4_nontrivial (uint32_t *xattr, ssize_t nbytes)
    if ACLs are not supported as errno is set in that case also.
    Set *AI to ACL info regardless of return value.
    FLAGS should be a <dirent.h> d_type value, optionally ORed with
-   AT_SYMLINK_FOLLOW; if the d_type value is not known,
+   ACL_SYMLINK_FOLLOW; if the d_type value is not known,
    use DT_UNKNOWN though this may be less efficient.
-   If FLAGS & AT_SYMLINK_FOLLOW, follow symlinks when retrieving ACL info;
+   If FLAGS & ACL_SYMLINK_FOLLOW, follow symlinks when retrieving ACL info;
    otherwise do not follow them if possible.  */
 int
 file_has_aclinfo (MAYBE_UNUSED char const *restrict name,