[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 02/11] dfa: introduce contexts for the values in d->success
From: |
arnold |
Subject: |
Re: [PATCH 02/11] dfa: introduce contexts for the values in d->success |
Date: |
Wed, 4 Jan 2012 10:35:10 -0800 |
> >> +#define CTX_NONE 1
> >> +#define CTX_LETTER 2
> >> +#define CTX_NEWLINE 4
> >> +
> >
> > Is there any reason, in this day and age, to still be using defines
> > instead of enums for something like this?
>
> No real reason, except going along with the rest of the dfa code.
Sounds like a good excuse to upgrade the rest of dfa.c :-)
> Note that you wouldn't always get meaningful names when debugging,
> because more than one bit can be set.
Yes, I know. But it's still an improvement.
Just a suggestion.
Thanks,
Arnold