bug-grep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#16232: [PATCH] grep: make --ignore-case (-i) faster (sometimes 10x)


From: arnold
Subject: bug#16232: [PATCH] grep: make --ignore-case (-i) faster (sometimes 10x) in multibyte locales
Date: Thu, 20 Feb 2014 10:22:49 -0700
User-agent: Heirloom mailx 12.4 7/29/08

Jim Meyering <address@hidden> wrote:

> Hi Paul,
>
> In case your bug fix looks safe/small, and is ready, ...
>
> I'm hoping to release 2.18 today, with the attached commits.
> Changes since yesterday: comment/log tweaks, and I've hoisted the using_utf8
> test in trivial_case_ignore to precede the two memchr tests.

Hi Jim.

Why copy the using_utf8() routine out of dfa.c?  Why not just link
to it instead?  If it's static, make it extern... That way if the
logic ever changes then it only has to be changed in one place.

Just a thought. :-)

Arnold





reply via email to

[Prev in Thread] Current Thread [Next in Thread]