[bug #63613] [mm] first TM number omitted in memorandum type 1

[G. Branden Robinson]

Follow-up Comment #2, bug #63613 (group groff):


[comment #0 original submission:]
> Ignoring the overprinting of "subject:", "date:" and "from:" for the
moment,

These and many other infelicities with the memorandum types were have been
getting fixed over the course of this year.  Here's a sample, including the
commit that fixed the foregoing.


commit 8d7785490f4619ed5a2a7b76833ae6ee429a053a
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Mon Jun 10 05:57:08 2024 -0500

    [mm]: Regression-test Savannah #65865.
    
    * contrib/mm/tests/cover-page-info-is-present.sh: Do it.
    * contrib/mm/mm.am (mm_TESTS): Run test.
    
    Test fails at this commit.

commit 8f5647956950a6cb5ac2b40704f2d73e57228a21
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Mon Jun 10 05:28:01 2024 -0500

    [mm]: Fix Savannah #65865 (cover sheet firm name).
    
    * contrib/mm/mm/0.MT: Move `cov@print-firm` call to where it works.
      Annotate the fairly subtle point revealed.
    
    Fixes <https://savannah.gnu.org/bugs/?65865>.  Problem appears to date
    back to commit bd5385e4ea, 17 November 1991 (groff 1.04, the first that
    shipped an implementation of mm).

commit 852111fc657a98a15dd529579b9c76847d4d0af8
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Mon Jun 10 07:31:42 2024 -0500

    [mm]: Align memorandum captions with DWB 3.3 mm.
    
    * contrib/mm/mm/0.MT: Align memorandum captions with DWB 3.3 mm.
    
    * contrib/mm/groff_mm.7.man <MT>: Document this.  Also fix error;
      omitting the argument implies memorandum type 1, not 0.
    
    * contrib/mm/tests/cover-page-info-is-present.sh: Update test
      expectations.

commit ace17af9469d6ee0f91f857801633c22854e305f
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Fri Jun 14 10:10:42 2024 -0500

    [mm]: Heavily revise `MT` output cosmetics.
    
    * contrib/mm/mm/0.MT: Revise to more closely approximate DWB 3.3 troff
      output.
    
      (cov@print-title): Use `SP` macro instead of `MOVE`.  Honor argument
      instead of ignoring it.  Save and restore the adjustment mode, and
      left-align text instead of turning off filling.  The latter (1) lost
      track of whether filling was enabled in the document already (though
      it _probably_ was) and more importantly (2) permitted lengthy charging
      or filing case numbers to overprint author information.  Use `nop` to
      maintain logical indentation when formatting output.  Use `br`
      requests to separate title/subject and the charging and filing case
      numbers.  Favor font selection requests over escape sequences.
    
      (cov@print-authors): Use `rt` request instead of `MOVE` macro, to
      return to the vertical position marked at the end of the
      `cov@print-date` macro (which could format more than one line of
      output).  Suspend and restore hyphenation since the context is
      crowded, not all names follow English hyphenation patterns, and
      arguments after the first to `AU` are often codes or abbreviations.
      Avoid disabling filling using same technique as above.  Arrange `AU`
      arguments 3-6 as DWB 3.3 does.  Stop formatting a literal `TM` in the
      output; DWB 3.3 didn't do this.  (Worse, we were putting it there even
      if no technical memorandum numbers were defined.)  Drop unnecessary
      `PGFORM` call.
    
      (cov@print-au1, cov@print-au2): Internally document what these macros
      are for (formatting `AU` arguments, some of which get special
      treatment), and align with DWB 3.3 output.
    
      (cov@print-date): Use `sp` request instead of `MOVE` macro; we can't
      call `SP` because this motion is negative (upward).  Avoid disabling
      filling using same technique as above.  Drop unnecessary `PGFORM`
      call.  Use `mk` to mark the bottom of the date output.
    
      (cov@print-firm): Return early if no firm name defined.  Use `sp`
      request instead of `MOVE` macro; we can't call `SP` because this
      motion is negative (upward).  Align firm name left instead of right.
      Set firm name in Helvetica roman if Helvetica family is available; in
      nroff mode, use bold.  Use `nop` to maintain logical indentation when
      formatting output.
    
      (cov@print-abstract):  Favor font selection requests over escape
      sequences.
    
      (initialization): Define several registers to vertically and
      horizontally arrange the document metadata.  Adjust verical spacing
      around abstract and its caption.  Favor font selection requests over
      escape sequences.
    
    * contrib/mm/m.tmac (let*mt-sign): Set signatures, except for the
      secretarial annotation, using the metadata font.
    
    * contrib/mm/tests/cover-page-info-is-present.sh: Update test
      expectations.

commit b768c274c3d07b3062a3e2603793bfe6fd1dbd4d
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Fri Jun 14 10:52:08 2024 -0500

    [mm]: Test memorandum output more rigorously.
    
    * contrib/mm/tests/artifacts/memorandum.0:
    * contrib/mm/tests/artifacts/memorandum.1:
    * contrib/mm/tests/artifacts/memorandum.2:
    * contrib/mm/tests/artifacts/memorandum.3:
    * contrib/mm/tests/artifacts/memorandum.4:
    * contrib/mm/tests/artifacts/memorandum.5:
    * contrib/mm/tests/artifacts/memorandum.custom: Add expected
      renderings.
    * contrib/mm/mm.am (EXTRA_DIST): Ship them.
    
    * contrib/mm/tests/cover-page-info-is-present.sh: Replace this test...
    * contrib/mm/tests/memoranda-format-correctly.sh: ...with this one.
    * contrib/mm/mm.am (mm_TESTS): Run the new test instead of the old one.




    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?63613>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/

signature.asc
Description: PGP signature