Re: [PATCH] squash4: fix handling of fragments and sparse files

[Carlo Caione]

On Sat, Feb 18, 2017 at 9:16 AM, Andrei Borzenkov <address@hidden> wrote:
> 1. Do not assume block list and fragment are mutually exclusive. Squash
> can pack file tail as fragment (unless -no-fragments is specified); so
> check read offset and read either from block list or from fragments as
> appropriate.
>
> 2. Support sparse files with zero blocks.
>
> 3. Fix fragment read - frag.offset is absolute fragment position,
> not offset relative to ino.chunk.
>
> Reported and tested by Carlo Caione <address@hidden>
>
> ---
>
> @Vladimir: we need regression tests for both of these cases. We could real 
> small
> files only by accident - block list was zero, so it appeared to work.
>
> @Carlo, please test. I'm surprised it worked for you even without fragments as
> your file is sparse and grub immediately choked on the first zero block.

Just tested. And it works fine for me.

Thanks,


-- 
Carlo Caione  |  +39.340.80.30.096  |  Endless