[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: guile 1.9.0 scm_read_hash_extend gc trouble
From: |
Neil Jerram |
Subject: |
Re: guile 1.9.0 scm_read_hash_extend gc trouble |
Date: |
Sat, 27 Jun 2009 22:53:35 +0100 |
User-agent: |
Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) |
address@hidden (Ludovic Courtès) writes:
> The attached patch adds a new `scm_t_off' type, whose definition does
> not depend on the application's `_FILE_OFFSET_BITS' value. Can you
> confirm that it allows you to build Guile with 32-bit offsets and Snd
> with 64-bit offsets (or vice versa)?
>
> Neil: Does this sound like the right approach?
Yes, this looks great. (In case it makes a difference, I've reviewed
the master commit, not the patch that you put in email.)
Also I think it means that we can delete some code that was needed to
handle the possibility that off_t might be 32-bit on a platform that
also supports large files.
- In scm_seek (), the "if (SCM_OPFPORTP (fd_port))" block is now not
needed, because the following more general "if (SCM_OPPORTP
(fd_port))" case will handle 64-bit correctly.
- Therefore scm_i_fport_seek () can be removed.
- The "#if GUILE_USE_64_CALLS && HAVE_STAT64 && SIZEOF_OFF_T !=
SIZEOF_OFF64_T" implementation of fport_seek () can be removed,
because fport_seek () is now always identical to
fport_seek_or_seek64 ().
- Plus the same things again but for "truncate" instead of "seek".
Would you agree?
Regards,
Neil
- guile 1.9.0 scm_read_hash_extend gc trouble, Bill Schottstaedt, 2009/06/21
- Re: guile 1.9.0 scm_read_hash_extend gc trouble, Neil Jerram, 2009/06/21
- Re: guile 1.9.0 scm_read_hash_extend gc trouble, Neil Jerram, 2009/06/21
- Re: guile 1.9.0 scm_read_hash_extend gc trouble, Bill Schottstaedt, 2009/06/22
- Re: guile 1.9.0 scm_read_hash_extend gc trouble, Neil Jerram, 2009/06/22
- Re: guile 1.9.0 scm_read_hash_extend gc trouble, Bill Schottstaedt, 2009/06/23
- Re: guile 1.9.0 scm_read_hash_extend gc trouble, Ludovic Courtès, 2009/06/23
- Re: guile 1.9.0 scm_read_hash_extend gc trouble,
Neil Jerram <=
- Re: guile 1.9.0 scm_read_hash_extend gc trouble, Ludovic Courtès, 2009/06/27
- Re: guile 1.9.0 scm_read_hash_extend gc trouble, Ludovic Courtès, 2009/06/29
- Re: guile 1.9.0 scm_read_hash_extend gc trouble, Neil Jerram, 2009/06/29
- Re: guile 1.9.0 scm_read_hash_extend gc trouble, Bill Schottstaedt, 2009/06/24
Re: guile 1.9.0 scm_read_hash_extend gc trouble, Thien-Thi Nguyen, 2009/06/23