[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#72547: [PATCH 1/9] tests: Check TCP_NODELAY for non-zero instead of
From: |
Tomas Volf |
Subject: |
bug#72547: [PATCH 1/9] tests: Check TCP_NODELAY for non-zero instead of 1. |
Date: |
Sat, 10 Aug 2024 00:54:27 +0200 |
POSIX does not explicitly say that stored value using setsockopt will be
returned by getsockopt. At least for TCP_NODELAY on Darwin they do
differ. Darwin returns internal define TF_NODELAY (4) instead of 1 the
test expected. Since for boolean flags "non-zero is true", rewrite the
test to check just that.
* test-suite/tests/00-socket.test ("setsockopt AF_INET")
["IPPROTO_TCP TCP_NODELAY"]: Check for non-zero value from getsockopt.
---
test-suite/tests/00-socket.test | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test-suite/tests/00-socket.test b/test-suite/tests/00-socket.test
index b3692f61a..17e686225 100644
--- a/test-suite/tests/00-socket.test
+++ b/test-suite/tests/00-socket.test
@@ -147,7 +147,7 @@
(pass-if "IPPROTO_TCP TCP_NODELAY"
(let ((sock (socket AF_INET SOCK_STREAM 0)))
(setsockopt sock IPPROTO_TCP TCP_NODELAY 1)
- (eqv? 1 (getsockopt sock IPPROTO_TCP TCP_NODELAY))))))
+ (not (eqv? 0 (getsockopt sock IPPROTO_TCP TCP_NODELAY)))))))
;;;
--
2.45.2
- bug#72547: [PATCH 0/9] Make test suite pass on macOS., Tomas Volf, 2024/08/09
- bug#72547: [PATCH 1/9] tests: Check TCP_NODELAY for non-zero instead of 1.,
Tomas Volf <=
- bug#72547: [PATCH 3/9] tests: Skip hole-related port tests on Darwin., Tomas Volf, 2024/08/09
- bug#72547: [PATCH 2/9] tests: Skip tests of abstract Unix sockets on Darwin., Tomas Volf, 2024/08/09
- bug#72547: [PATCH 5/9] tests: Skip mkdtemp test for invalid template on Darwin., Tomas Volf, 2024/08/09
- bug#72547: [PATCH 4/9] filesys.c: Fix readlink for ports on Darwin., Tomas Volf, 2024/08/09
- bug#72547: [PATCH 7/9] tests: Fix spawn if file not found with Gnulib., Tomas Volf, 2024/08/09
- bug#72547: [PATCH 6/9] tests: Fix spawn with #:environment on MacOS., Tomas Volf, 2024/08/09
- bug#72547: [PATCH 8/9] Do not depend on tmpnam in posix.test., Tomas Volf, 2024/08/09
- bug#72547: [PATCH 9/9] posix.c: Set errno when pipe2 is not available and flags provided., Tomas Volf, 2024/08/09