[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#72547: [PATCH 8/9] Do not depend on tmpnam in posix.test.
From: |
Tomas Volf |
Subject: |
bug#72547: [PATCH 8/9] Do not depend on tmpnam in posix.test. |
Date: |
Sat, 10 Aug 2024 00:54:34 +0200 |
`tmpnam' is a deprecated procedure that can be excluded during a
configure (`--disable-tmpnam'). There currently was a single test
relying on it, and therefore failing is such configuration. This commit
switches to mkstemp instead.
* test-suite/tests/posix.test ("system*"): Use mkstemp instead of
tmpnam.
---
test-suite/tests/posix.test | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/test-suite/tests/posix.test b/test-suite/tests/posix.test
index 95692eeb1..c4360b79e 100644
--- a/test-suite/tests/posix.test
+++ b/test-suite/tests/posix.test
@@ -365,7 +365,8 @@
(pass-if-equal "https://bugs.gnu.org/52835"
"bong\n"
- (let ((file (tmpnam)))
+ (let* ((port (mkstemp "T-XXXXXX"))
+ (file (port-filename port)))
;; Redirect stdout and stderr to FILE.
(define status
(call-with-output-file file
@@ -376,8 +377,9 @@
(lambda ()
(system* "sh" "-c" "echo bong >&2"))))))))
+ (delete-file file)
(and (zero? (status:exit-val status))
- (call-with-input-file file get-string-all))))
+ (get-string-all port))))
(pass-if-equal "https://bugs.gnu.org/63024"
0
--
2.45.2
- bug#72547: [PATCH 0/9] Make test suite pass on macOS., Tomas Volf, 2024/08/09
- bug#72547: [PATCH 1/9] tests: Check TCP_NODELAY for non-zero instead of 1., Tomas Volf, 2024/08/09
- bug#72547: [PATCH 3/9] tests: Skip hole-related port tests on Darwin., Tomas Volf, 2024/08/09
- bug#72547: [PATCH 2/9] tests: Skip tests of abstract Unix sockets on Darwin., Tomas Volf, 2024/08/09
- bug#72547: [PATCH 5/9] tests: Skip mkdtemp test for invalid template on Darwin., Tomas Volf, 2024/08/09
- bug#72547: [PATCH 4/9] filesys.c: Fix readlink for ports on Darwin., Tomas Volf, 2024/08/09
- bug#72547: [PATCH 7/9] tests: Fix spawn if file not found with Gnulib., Tomas Volf, 2024/08/09
- bug#72547: [PATCH 6/9] tests: Fix spawn with #:environment on MacOS., Tomas Volf, 2024/08/09
- bug#72547: [PATCH 8/9] Do not depend on tmpnam in posix.test.,
Tomas Volf <=
- bug#72547: [PATCH 9/9] posix.c: Set errno when pipe2 is not available and flags provided., Tomas Volf, 2024/08/09