[PATCH] ui: Add a 'define-diagnostic' macro. (was: Enhanced 'warning')

[Nikita Karetnikov]

> This is a macro-generating macro.  In the body of the generated macro,
> above, there are 4 occurrences of ‘...’.  But these ellipses have no
> meaning in the outer macro; they are just meaningful in the context of
> the generated macro, hence the error.

> Instead, you should replace all 4 occurrences with (... ...).

> Yes, it’s always surprising at first.  ;-)

Yep, could you add it to the manual?  There is only a reference to this
book [1] which briefly discusses the topic.

I'm attaching the patch that adds a 'define-diagnostic' macro.  Can I
push it to 'master'?

I ran 'grep' to find things which use "warning" or "leave."  I guess
it's possible to change other functions (the ones that use 'error' and
'format').  But it will probably trigger a rebuild.  So what should I
do?

Also, is it possible to move 'report-error' inside 'leave'?

Finally, I haven't tested each change.  All tests pass and there are no
warnings.  Is it good enough?

[1] http://scheme.com/tspl4/

0001-ui-Add-a-define-diagnostic-macro.patch
Description: Text Data

pgpC63nb7jZwb.pgp
Description: PGP signature