|
From: | Ludovic Courtès |
Subject: | bug#25917: [PATCH] file-systems: Factorize file-system-packages. |
Date: | Fri, 17 Mar 2017 10:03:52 +0100 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Hi Danny, Danny Milosavljevic <address@hidden> skribis: > * gnu/system/linux-initrd.scm (base-initrd): Move helper-packages body to ... > * gnu/system/file-systems.scm (file-system-packages): ... here. > Also export it. > * gnu/services/base.scm (file-system-shepherd-service): Set PATH by using > file-system-packages. Exactly what we need! Could you just make it two patches: 1. introduce ‘file-system-packages’; 2. Use it in ‘file-system-shepherd-service’. > +(define (file-system-type-predicate type) > + (lambda (fs) > + (string=? (file-system-type fs) type))) > + > +(define* (file-system-packages file-systems #:key (volatile-root? #f)) Please add a docstring to these procedures. You can also remove the now-unused ‘file-system-type-predicate’ procedure that is in ‘base-initrd’. OK with these changes. Thank you! Ludo’.
[Prev in Thread] | Current Thread | [Next in Thread] |