[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#25917: [PATCH] file-systems: Factorize file-system-packages.
From: |
Danny Milosavljevic |
Subject: |
bug#25917: [PATCH] file-systems: Factorize file-system-packages. |
Date: |
Fri, 17 Mar 2017 13:19:58 +0100 |
Hi Ludo,
On Fri, 17 Mar 2017 10:03:52 +0100
address@hidden (Ludovic Courtès) wrote:
> You can also remove the now-unused ‘file-system-type-predicate’
> procedure that is in ‘base-initrd’.
It's still used there (in order to determine the Linux modules). Should I also
export 'file-system-type-predicate` from file-systems.scm and use that in
'base-initrd` ? I thought it was too special-case to be a public function.
Also, it seems that the new version (which now uses
`set-path-environment-variable') clears the old PATH whereas the previous
version prepended to it.
The previous version has:
(setenv "PATH"
(string-append
#$e2fsprogs "/sbin:"
"/run/current-system/profile/sbin:"
$PATH)))
(What does "$" without "#" do?)
The new version would have:
(lambda ()
(set-path-environment-variable "PATH"
'("bin" "sbin")
'#$packages))
It works fine - however, I get a warning that PATH has been unset at bootup.
Should we replicate the previous behaviour?
What's up with the hard-coded "/run/current-system/profile/sbin" ?
- bug#25917: operating-system file-system with (check? #t) but (needed-for-boot #f) pauses boot until user interaction, (continued)
- bug#25917: operating-system file-system with (check? #t) but (needed-for-boot #f) pauses boot until user interaction, Ludovic Courtès, 2017/03/11
- bug#25917: [PATCH] services: Don't check filesystem even if #:check? if not #:needed-for-boot., Danny Milosavljevic, 2017/03/12
- bug#25917: [PATCH] services: Don't check filesystem even if #:check? if not #:needed-for-boot., Ludovic Courtès, 2017/03/13
- bug#25917: [PATCH] services: Don't check filesystem even if #:check? if not #:needed-for-boot., Danny Milosavljevic, 2017/03/13
- bug#25917: [PATCH] services: Don't check filesystem even if #:check? if not #:needed-for-boot., Ludovic Courtès, 2017/03/14
- bug#25917: [PATCH] services: Don't check filesystem even if #:check? if not #:needed-for-boot., Danny Milosavljevic, 2017/03/14
- bug#25917: [PATCH] services: Don't check filesystem even if #:check? if not #:needed-for-boot., Ludovic Courtès, 2017/03/14
bug#25917: [PATCH v2] services: If a filesystem is not marked as needed for boot, don't check it even if told to check it., Danny Milosavljevic, 2017/03/12
bug#25917: [PATCH] file-systems: Factorize file-system-packages., Danny Milosavljevic, 2017/03/16
bug#25917: [PATCH v2] services: file-system-shepherd-service: Make it find the fsck programs., Danny Milosavljevic, 2017/03/18