bug-guix
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#32661: modify-phases: detect invalid phase addition


From: Ricardo Wurmus
Subject: bug#32661: modify-phases: detect invalid phase addition
Date: Fri, 07 Sep 2018 23:50:02 +0200
User-agent: mu4e 1.0; emacs 26.1

It is possible to add a build phase to a non-existing phase without an
error.  The new build phase will simply not be executed.

This is problematic when an inherited package augments the original
package’s phases and the original package is changed.  Imagine that the
parent package’s “pre-configure” phase is removed:

((#:phases original-phases)
`(modify-phases ,original-phases
  (add-after 'pre-configure 'patch-this
    (lambda _ …))))

This would cause the “patch-this” phase in the child package to be
skipped without warning.

This kind of thing can be especially confusing in the bootstrap, which
makes heavy use of inheritance.

--
Ricardo






reply via email to

[Prev in Thread] Current Thread [Next in Thread]