|
From: | Tomas Volf |
Subject: | bug#72130: test-driver.scm produces .trs file with undefined behavior |
Date: | Mon, 15 Jul 2024 23:39:38 +0200 |
Hello, currently there are two issues with build-aux/test-driver.scm. 1. :test-global-result: is mistyped as :global-test-result:. 2. Summarizing metadata are outputted on end of each test-group, meaning they will be present multiple times, if there is more than one test group. First is somewhat fine, since, per the manual page, unknown keys are (for now) ignored. However second is explicitly stated to be undefined behavior, so it should be fixed. I am CC-ing both authors listed in the test-driver.scm, since I have no idea where the upstream is (it seems to be just copied around between projects?). You can find fixes for the first (0001) and second (0002) issues attached to this email. I am also including two additional patches (0003 refining :test-global-result: for XPASS as XXX mentioned, 0005 improving support for test group since it was somewhat lacking) which I consider useful and I have applied them to my local copy of test-driver.scm file. Feel free to apply them, or ignore them, as you see fit. Have a nice day, Tomas Volf -- There are only two hard things in Computer Science: cache invalidation, naming things and off-by-one errors.
0001-build-test-driver.scm-Fix-test-global-result-.trs-me.patch
Description: Text document
0002-build-test-driver.scm-Output-singleton-metadata-just.patch
Description: Text document
0003-build-test-driver.scm-Refine-the-global-test-result.patch
Description: Text document
0005-build-test-driver.scm-Utilize-test-runner-group-path.patch
Description: Text document
signature.asc
Description: PGP signature
[Prev in Thread] | Current Thread | [Next in Thread] |