bug-gzip
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] build: do not override gnulib-provided AM_CFLAGS options


From: Jim Meyering
Subject: [PATCH] build: do not override gnulib-provided AM_CFLAGS options
Date: Mon, 11 Jan 2010 11:56:01 +0100

FYI,

>From 033dda0eeed5b886eb862ba6e12628f2e4011324 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Mon, 11 Jan 2010 11:51:13 +0100
Subject: [PATCH] build: do not override gnulib-provided AM_CFLAGS options

Avoid a warning from automake:
lib/Makefile.am:24: AM_CFLAGS multiply defined in condition TRUE ...
lib/gnulib.mk:30: ... `AM_CFLAGS' previously defined here
lib/Makefile.am:20:   `lib/gnulib.mk' included from here

* lib/Makefile.am (AM_CFLAGS): Append $(WARN_CFLAGS) and
$(WERROR_CFLAGS), i.e., use "+=", not "=".
This was introduced via 2009-12-17 commit 0341fc22,
"build: with --enable-gcc-warnings, use -Werror",
but fortunately is not a bug, because the definition
it would have overridden was always empty.
---
 lib/Makefile.am |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/Makefile.am b/lib/Makefile.am
index e817fe7..6f4f55e 100644
--- a/lib/Makefile.am
+++ b/lib/Makefile.am
@@ -21,7 +21,7 @@ include gnulib.mk

 libgzip_a_LIBADD += $(LIBOBJS)
 libgzip_a_DEPENDENCIES += $(LIBOBJS)
-AM_CFLAGS = $(WARN_CFLAGS) $(WERROR_CFLAGS)
+AM_CFLAGS += $(WARN_CFLAGS) $(WERROR_CFLAGS)

 match.$(OBJEXT): match.c
        cp $(srcdir)/match.c _match.S
--
1.6.6.439.gaf68f




reply via email to

[Prev in Thread] Current Thread [Next in Thread]