bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: console-client patch: selecting amount of font slots


From: Alfred M. Szmidt
Subject: Re: console-client patch: selecting amount of font slots
Date: Sat, 12 Jul 2003 07:14:34 +0200

Just some minor nit-picks.  Overall the patch looks ok.

   @@ -62,6 +62,9 @@ static char *vga_display_font_bold;
           "/lib/hurd/fonts/vga-system-bold-italic.bdf"
    static char *vga_display_font_bold_italic;

   +/* Use all colors when set, otherwise use double font slots.  */
   +static int vga_display_full_color = 0;
   +

I would prefer to have the comment for VGA_DISPLAY_FULL_COLOR to be:

 If zero use all colors, else use double font slots.

Less thinking about what "set" means.

   @@ -171,12 +174,23 @@ parse_startup_args (int no_exit, int arg
           }                                            \
          } while (0)

   +#define PARSE_FONT_OPT_NOARGS(x,y,z)                \
   +  {                                         \
   +    if (!strcmp (argv[*next], x))           \
   +      {                                             \
   +    printf("foo\b");                        \

Left from debugging?




reply via email to

[Prev in Thread] Current Thread [Next in Thread]