Bug#190732: [PATCH] hurd/libdiskfs/dir-renamed.c

[Marco Gerards]

Marcus Brinkmann <marcus.brinkmann@ruhr-uni-bochum.de> writes:

> Hi,
> 
> I think the first patch is basically correct, although I wonder about
> the following details:
> 
> 1. What errors do you still expect from the second time diskfs_lookup is
> invoked with REMOVE?  Is there any error that is allowed at that time?
> If there is, the change is correct.

I didn't see this patch yet (only the first one, which is terribly
wrong, but it was written by someone else). Is it ok if I have a look
at this patch tomorrow?

> 2. Is it possible, and according to diskfs.h it should be, to just
> call dir_lookup with REMOVE only once, at the point you introduced it
> in your patch, and store the dirstat until it is needed for the actual
> disks_dirremove call.  This saves one lookup call.  Can you try such a
> change and look into the code if it is feasible?

Funny, I wrote such patch yesterday. There is still a bug in what I
wrote, so I didn't send it in yet. Do you want me to fix it or send it
in or is saying what you proposed is possible and easy to do enough?
:)

I have a look at this patch tommorrow to check if it has the same
problem with my patch and send in a new patch or I'll say what the
problem is.

Thanks,
Marco