[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[patch #1780] [Patch #1780] Make it possible to choose the visual and au
From: |
noreply |
Subject: |
[patch #1780] [Patch #1780] Make it possible to choose the visual and audible bell |
Date: |
Thu, 31 Jul 2003 18:24:04 -0400 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030313 |
Patch #1780 has been updated.
Project:
Category: None
Status: Open
Summary: Make it possible to choose the visual and audible bell
Follow-Ups:
Date: Thu 07/31/2003 at 22:13
By: marcus
Comment:
Please use uppercase characters for enumerator values, ie BELL_OFF etc.
Instead using an enumerator, you could also just use a function pointer (ie, 0,
cons_vcons_flash, or cons_vcons_bell). That saves you the hassle to repeat the
if in both places, although it obscures the code a bit. Not sure if it is
worth it, what do you think?
I don't think you want <strings.h>, but rather <string.h>.
Don't abbreviate copyright years. It is 2003, not 03.
We should allow "--visual-bell=visual" and "--audible-bell=audible" for
consistency and easier scripting.
When this is fixed, it can go in. Please submit a revised patch.
-------------------------------------------------------
Date: Fri 08/01/2003 at 00:24
By: marco_g
Comment:
In the new patch is all what you have asked for execept the function pointer. I
do not think it is worth it and it makes simple code too complex.
-------------------------------------------------------
-------------------------------------------------------
For more info, visit:
http://savannah.gnu.org/patch/?func=detailpatch&patch_id=1780&group_id=30
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/