[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Corrected Entropy Patch
From: |
Thomas Schwinge |
Subject: |
Re: Corrected Entropy Patch |
Date: |
Mon, 6 Aug 2007 19:57:07 +0200 |
User-agent: |
Mutt/1.5.11 |
Hello!
On Mon, Aug 06, 2007 at 01:38:31PM -0400, Michael Casadevall wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> I've fixed the patch correcting the GCS violations, and I'm sending
Thanks!
> it with a different mailer which shouldn't mutate the patch:
Didn't work out:
> - --- configfrag.ac 4 Aug 2007 18:50:19 -0000 1.1.2.7
> +++ configfrag.ac 6 Aug 2007 15:05:19 -0000
To fix this you should switch away from this sh*tty in-line gpg signing
and do that properly :-). Alternatively just upload your patch somewhere
and have us download it from there. flubber or clubber come to mind, for
example.
> - -AC_DEFINE([STAT_TIME], [1], [STAT_TIME])
> +AC_DEFINE([STAT_TIME], [0], [STAT_TIME])
Also, this doesn't belong into your patch, I suppose.
> - -
Please don't remove those.
I can't look further through your patch at the moment, as I have to leave
in a few minutes.
If it's not too cumbersome for you, please re-submit with those issues
fixed (there may be others as well, I don't know yet) or otherwise I'll
apply the patch to a local temporary tree, fix those things and commit it
-- if everything apart from those minor formatting et al. stuff if fine,
of course.
Regards,
Thomas
signature.asc
Description: Digital signature