bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 6/8] Add missing functions to input_driver_test.


From: olafBuddenhagen
Subject: Re: [PATCH 6/8] Add missing functions to input_driver_test.
Date: Wed, 11 Aug 2010 07:59:13 +0200
User-agent: Mutt/1.5.20 (2009-06-14)

Hi,

On Wed, Aug 04, 2010 at 04:20:04AM -0300, Diego Nieto Cid wrote:

> +void console_switch_back(void)
> +{
> +  puts("Switch back\n");

Hm... I'm slightly ambivalent about the use of puts(). It make a lot of
sense technically in this case; and now that I think about it, I wonder
why it isn't used much more often...

However, as all the other code in this file uses printf() for this
purpose, I tend to think that it might be better to stick to that for
consistency?

-antrik-



reply via email to

[Prev in Thread] Current Thread [Next in Thread]