Re: GNU Mach: IDE disk drives with unusual C/H/S

[Thomas Schwinge]

Hi Ivan!

On Tue, 27 Nov 2012 16:36:24 +0700, Ivan Shmakov <oneingray@gmail.com> wrote:
> >>>>> Thomas Schwinge <thomas@codesourcery.com> writes:
> 
> […]
> 
>  > Does anyone spot any problems, or does this need more testing, or is
>  > it OK to commit right away?
> 
>       I see none (but then, I'm not really a Mach or ATA expert),
>       apart from a few style and formatting issues.

Great, and thanks for having a look!


>  > +  if (id->cyls == 16383 && id->sectors == 63 &&
>  > +      (id->heads == 15 || id->heads == 16) &&
>  > +      id->lba_capacity >= 16383*63*id->heads)
>  >            return 1;       /* lba_capacity is our only option */
>  > -  }
>  > +
> 
>       Here, a diff line could've been saved by adding an opening { to
>       the if above.  (IOW, no need to drop the C grouping construct
>       from here.)
> 
> […]

Generally you're right with your suggestions (especially so in context of
the GNU Coding Standards).  However note that I'm just importing this
code from upstream Linux 2.0.40, and when doing such merges, the goal
(usually) is to diverge from the upstream code as little as possible (to
ease future merge) -- thus the "unusual" formatting changes.


Grüße,
 Thomas

pgpDFvIJUU2Qy.pgp
Description: PGP signature