Re: [PATCH 06/14] proc: turn {init, add}str, compare_versions into normal functions

[Justus Winter]

Hi :)

Quoting Richard Braun (2013-11-09 14:00:35)
> On Sat, Nov 09, 2013 at 11:08:28AM +0100, Justus Winter wrote:
> > Quoting Ludovic =?utf-8?Q?Court=C3=A8s?= (2013-11-09 00:31:08)
> > > Justus Winter <4winter@informatik.uni-hamburg.de> skribis:
> > > 
> > > > rebuild_uname uses {init,add}str to incrementally build a version
> > > > string, and compare_versions to sort the versions array. Previously
> > > > those functions were defined as nested functions.
> > > 
> > > Isn’t this a bit controversial given the discussion on that topic?  :-)
> > 
> > Were we having the same discussion? I count Samuel, Richard and me in
> > favor of that kind of change, Roland and you against it.
> 
> It's not a matter of mere numbers. We need consensus, and if we can't
> achieve it, the actual maintainer (who currently is Samuel) decides.

I didn't mean to imply that. But given how the discussion was going
(or not), I think it's reasonable to propose the change. By doing so,
I hope to demonstrate that I care enough to do it, how invasive such a
change might be, and what possible benefits might arise from such
changes.

And even if the transformations are not merged, the fixups in this
series can be.

Justus