[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] libports: fix the thread counts in case the thread creation
From: |
Neal H. Walfield |
Subject: |
Re: [PATCH] libports: fix the thread counts in case the thread creation fails |
Date: |
Sun, 10 Nov 2013 12:03:19 +0100 |
User-agent: |
Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (Gojō) APEL/10.8 Emacs/23.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) |
At Sun, 10 Nov 2013 11:54:20 +0100,
Samuel Thibault wrote:
>
> Neal H. Walfield, le Sun 10 Nov 2013 11:38:04 +0100, a écrit :
> > At Sat, 9 Nov 2013 18:21:51 +0100,
> > Samuel Thibault wrote:
> > > > + pthread_spin_lock (&lock);
> > > > + totalthreads--;
> > > > + nreqthreads--;
> > > > + pthread_spin_unlock (&lock);
> >
> > It might be a good idea use atomic operations instead of the spin lock
> > (which is what the spin lock is using behind the scenes anyways).
>
> It may not be possible: further down there is a decision taken depending
> on totalthreads/nreqthreads becoming 1, and thus you need a spinlock to
> make that coherent with the ++/--.
Too bad. Perhaps combining the quantities into a single word as
follows would work:
atomic.add(threads, 1<<16 | 1)
This has the further advantage of reducing the number of atomic
operations.
Neal
- [PATCH] libports: fix the thread counts in case the thread creation fails, Justus Winter, 2013/11/09
- Re: [PATCH] libports: fix the thread counts in case the thread creation fails, Samuel Thibault, 2013/11/09
- Re: [PATCH] libports: fix the thread counts in case the thread creation fails, Neal H. Walfield, 2013/11/10
- Re: [PATCH] libports: fix the thread counts in case the thread creation fails, Samuel Thibault, 2013/11/10
- Re: [PATCH] libports: fix the thread counts in case the thread creation fails,
Neal H. Walfield <=
- lockless thread management in libports (was: [PATCH] libports: fix the thread counts in case the thread creation fails), Justus Winter, 2013/11/11
- [PATCH] libports: implement lockless management of threads, Justus Winter, 2013/11/11
- Re: [PATCH] libports: implement lockless management of threads, Neal H. Walfield, 2013/11/11
- Re: [PATCH] libports: implement lockless management of threads, Justus Winter, 2013/11/12
- Re: [PATCH] libports: implement lockless management of threads, Samuel Thibault, 2013/11/12
- Re: [PATCH] libports: implement lockless management of threads, Emilio Pozuelo Monfort, 2013/11/13
- Re: [PATCH] libports: implement lockless management of threads, Justus Winter, 2013/11/15
- [PATCH] libports: implement lockless management of threads, Justus Winter, 2013/11/15
- Re: [PATCH] libports: implement lockless management of threads, Samuel Thibault, 2013/11/16
- Re: [PATCH] libports: implement lockless management of threads, Justus Winter, 2013/11/16