[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 10/11] i386/i386/db_trace.c: return reg value
|
From: |
Marin Ramesa |
|
Subject: |
Re: [PATCH 10/11] i386/i386/db_trace.c: return reg value |
|
Date: |
Wed, 20 Nov 2013 22:22:41 +0100 |
On 20.11.2013 22:10:54, Samuel Thibault wrote:
> Marin Ramesa, le Wed 20 Nov 2013 20:42:54 +0100, a écrit :
> > * i386/i386/db_trace.c (db_i386_reg_value): Return reg value.
>
> I don't see the returned value used anywhere. I'd say rather drop it
> than returning something which is already returned another way.
But if you make the function void this breaks the initialization of
db_variables struct near the begining of the file.
- [PATCH 03/11] i386/i386/db_interface.c: fix implicit declaration of function, (continued)
- [PATCH 03/11] i386/i386/db_interface.c: fix implicit declaration of function, Marin Ramesa, 2013/11/20
- [PATCH 04/11] i386/i386/db_interface.c: remove return value, Marin Ramesa, 2013/11/20
- [PATCH 05/11] i386/i386/db_interface.c: add comments after else and endif, Marin Ramesa, 2013/11/20
- [PATCH 06/11] i386/i386/db_interface.c: comment function and the calls, Marin Ramesa, 2013/11/20
- [PATCH 07/11] i386/i386/db_trace.c: cast to (int *), Marin Ramesa, 2013/11/20
- [PATCH 09/11] i386/i386/db_trace.c: don't cast to db_addr_t, Marin Ramesa, 2013/11/20
- [PATCH 08/11] i386/i386/db_trace.c: fix implicit declaration of function, Marin Ramesa, 2013/11/20
- [PATCH 10/11] i386/i386/db_trace.c: return reg value, Marin Ramesa, 2013/11/20
- [PATCH 11/11] i386/i386/trap.c: fix implicit declaration of function, Marin Ramesa, 2013/11/20
- Re: [PATCH 01/11] i386/i386/db_interface.c: fix passing from incompatible pointer type, Samuel Thibault, 2013/11/20