[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 1/4] lwip: Fix wrong error checks
From: |
Joan Lledó |
Subject: |
[PATCH 1/4] lwip: Fix wrong error checks |
Date: |
Sun, 31 Mar 2019 19:55:38 +0200 |
* lwip/lwip-util.c: init_ifs():
* Check for the value of ifc instead of in->dev_name
* lwip/port/netif/ifcommon.c:
* if_init(), if_terminate(): Check for null on ifc instead of netif
---
lwip/lwip-util.c | 4 ++--
lwip/port/netif/ifcommon.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/lwip/lwip-util.c b/lwip/lwip-util.c
index 57a94d52..69991b4c 100644
--- a/lwip/lwip-util.c
+++ b/lwip/lwip-util.c
@@ -181,7 +181,7 @@ init_ifs (void *arg)
/*
* Create a new interface and configre IPv4.
*
- * Fifth parameter (in->name) is a hook.
+ * Fifth parameter (ifc) is a hook.
*/
err = netifapi_netif_add
(netif, &in->address, &in->netmask, &in->gateway, &ifc, if_init,
@@ -189,7 +189,7 @@ init_ifs (void *arg)
if (err)
{
/* The interface failed to init */
- if (netif->state != in->dev_name)
+ if (netif->state != &ifc)
/* It failed after setting the control block, must free it */
mem_free (netif->state);
free (netif);
diff --git a/lwip/port/netif/ifcommon.c b/lwip/port/netif/ifcommon.c
index 11ede76d..c6179683 100644
--- a/lwip/port/netif/ifcommon.c
+++ b/lwip/port/netif/ifcommon.c
@@ -75,7 +75,7 @@ if_init (struct netif * netif)
{
struct ifcommon *ifc = netif_get_state (netif);
- if (netif == NULL)
+ if (ifc == NULL)
/* The user provided no interface */
return -1;
@@ -89,7 +89,7 @@ if_terminate (struct netif * netif)
error_t err;
struct ifcommon *ifc = netif_get_state (netif);
- if (netif == NULL)
+ if (ifc == NULL)
/* The user provided no interface */
return -1;
--
2.17.1