Re: [PATCH libpciaccess] hurd: Clients or nested arbiters don't touch ioports

[Joan Lledó]

Hi,

El 23/8/22 a les 10:36, Damien Zammit ha escrit:
> @@ -600,14 +599,14 @@ static const struct pci_system_methods hurd_pci_methods = 
> {
>       .read = pci_device_hurd_read,
>       .write = pci_device_hurd_write,
>       .fill_capabilities = pci_fill_capabilities_generic,
> -    .open_legacy_io = pci_device_x86_open_legacy_io,
> -    .close_io = pci_device_x86_close_io,
> -    .read32 = pci_device_x86_read32,
> -    .read16 = pci_device_x86_read16,
> -    .read8 = pci_device_x86_read8,
> -    .write32 = pci_device_x86_write32,
> -    .write16 = pci_device_x86_write16,
> -    .write8 = pci_device_x86_write8,
> +    .open_legacy_io = NULL,
> +    .close_io = NULL,
> +    .read32 = NULL,
> +    .read16 = NULL,
> +    .read8 = NULL,
> +    .write32 = NULL,
> +    .write16 = NULL,
> +    .write8 = NULL,
>       .map_legacy = pci_device_hurd_map_legacy,
>       .unmap_legacy = pci_device_hurd_unmap_legacy,
>   };

Those functions are declared at x86_pci.h precisely b/c they need to be 
known for hurd_pci.c. If you stop calling them you should remove them 
also from x86_pci.h and make them static in x86_pci.c