Re: [PATCH v11 0/2 hurd] Add irqhelp library and clean up ddekit
From:
Damien Zammit
Subject:
Re: [PATCH v11 0/2 hurd] Add irqhelp library and clean up ddekit
Date:
Sun, 24 Mar 2024 11:40:27 +0000
Hi Samuel,
-------- Original Message -------- On 24 Mar 2024, 9:32 pm, Samuel Thibault >... Your version 11 is however still accessing the `irq` local parameter, so it's still only by luck that it's working. You need to restore allocating the params structure to store irq and priv, which was precisely meant to avoid this kind issue.
Actually, the ddekit semaphore protects the irq variable from disappearing because the function is guaranteed to not return until after the semaphore has signalled it has run the thread_init and used the irq local.