bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH 03/23] Allow glibc to be compiled without EXEC_PAGESIZE


From: Florian Weimer
Subject: Re: [RFC PATCH 03/23] Allow glibc to be compiled without EXEC_PAGESIZE
Date: Mon, 25 Mar 2024 12:58:13 +0100
User-agent: Gnus/5.13 (Gnus v5.13)

* Florian Weimer:

> * Sergey Bugaev:
>
>> diff --git a/elf/dl-support.c b/elf/dl-support.c
>> index 2f502c8b..6375dc95 100644
>> --- a/elf/dl-support.c
>> +++ b/elf/dl-support.c
>> @@ -135,7 +135,11 @@ void *_dl_random;
>>  #include <dl-procruntime.c>
>>  #include <dl-procinfo.c>
>>  
>> -size_t _dl_pagesize = EXEC_PAGESIZE;
>> +size_t _dl_pagesize
>> +#ifdef EXEC_PAGESIZE
>> +  = EXEC_PAGESIZE
>> +#endif
>> +;
>
> I think the intent here is to initialize _dl_pagesize with a
> conservative default, to avoid initialization ordering issues.
> EXEC_PAGESIZE is supposed to be largest supported page size.

This was committed without addressing the comment above.

Thanks,
Florian




reply via email to

[Prev in Thread] Current Thread [Next in Thread]