Re: [PATCH 10/17] Make -fno-PIE etc. architecture-dependent

[Samuel Thibault]

Applied, thanks!

Sergey Bugaev, le mer. 27 mars 2024 19:18:34 +0300, a ecrit:
> There might be good reasons why Mach on x86 shouldn't be built as PIC/
> PIE, but there are also very good reasons to support PIE on other
> architectures. Potentially implementing KASLR is one such reason; but
> also the Linux AArch64 boot protocol (that the AArch64 port will use for
> booting) lets the bootloader load the kernel image at any address,
> which makes PIC pretty much required.
> ---
>  Makefile.am      | 4 ----
>  i386/Makefrag.am | 4 ++++
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/Makefile.am b/Makefile.am
> index ad38249b..357e8470 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -79,10 +79,6 @@ AM_CFLAGS += \
>       -fno-stack-protector
>  endif
>  
> -# We do not support or need position-independent
> -AM_CFLAGS += \
> -     -no-pie -fno-PIE -fno-pie -fno-pic
> -
>  # This must be the same size as port names, see e.g. ipc/ipc_entry.c
>  AM_CFLAGS += -DRDXTREE_KEY_32
>  
> diff --git a/i386/Makefrag.am b/i386/Makefrag.am
> index 5e7d4740..7a339417 100644
> --- a/i386/Makefrag.am
> +++ b/i386/Makefrag.am
> @@ -170,6 +170,10 @@ gnumach_LINKFLAGS += \
>       -T '$(srcdir)'/i386/ldscript
>  endif
>  
> +# We do not support or need position-independent
> +AM_CFLAGS += \
> +     -no-pie -fno-PIE -fno-pie -fno-pic
> +
>  AM_CFLAGS += \
>       -mno-3dnow \
>       -mno-mmx \
> -- 
> 2.44.0
> 
> 

-- 
Samuel
---
Pour une évaluation indépendante, transparente et rigoureuse !
Je soutiens la Commission d'Évaluation de l'Inria.