[bug #65588] A buffer overrun in handling of .SHELLFLAGS.

[malcolm cook]

Follow-up Comment #5, bug #65588 (group make):

I am experiencing a situation with GNU Make 4.4.1 that is I expect will be
resolved with the changes under consideration.

Can you possibly advise me how I can test it in my environment. I will build
make if needed.

In the following 4 one-liners, the first 3 work as expected but only the 4th
segfaults, resulting from the combination of using both .ONESHELL and special
characters in .SHELLFLAGS.


$ make -E $'SHELL=echo\n.SHELLFLAGS=hello\nall:\n\tworld\n\tsecond world' -s
hello world
hello second world
$ make -E $'.ONESHELL:\nSHELL=echo\n.SHELLFLAGS=hello\nall:\n\tworld\n\tsecond
world' -s
hello world
second world
$ make -E $'SHELL=echo\n.SHELLFLAGS="hello"\nall:\n\tworld\n\tsecond world'
-s
hello world
hello second world
$ make -E
$'.ONESHELL:\nSHELL=echo\n.SHELLFLAGS="hello"\nall:\n\tworld\n\tsecond world'
-s
/bin/sh -c "hello" world
second world
Segmentation fault (core dumped)


FWIW - I don't use `echo` as my SHELL.  My example is meant to be minimal and
illustrative.  I encountered this while trying to use


SHELL=duckdb 
.SHELLFLAGS= -c "attach 'mwftk.ddb'" -c


I have a workaround, but would like to have this fix.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?65588>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/

signature.asc
Description: PGP signature