bug-make
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug #66499] Parameter for option -j seems not to be validated and c


From: Paul Smith
Subject: Re: [bug #66499] Parameter for option -j seems not to be validated and can cause hangs
Date: Sun, 01 Dec 2024 17:21:18 -0500
User-agent: Evolution 3.54.1 (by Flathub.org)

On Sun, 2024-12-01 at 17:12 +0100, Henrik Carlqvist wrote:
> On Sun,  1 Dec 2024 09:10:04 -0500 (EST)
> "Paul D. Smith" <INVALID.NOREPLY@gnu.org> wrote:
> > F_GETPIPE_SZ will work on Linux but it's not portable (not part of
> > POSIX
> > fcntl)
> 
> Suggestion: Use F_GETPIPE_SZ as a limit when it does exist, if not,
> use some arbitrary big value which usually will be "big enough with a
> margin". I did use 10000 for a similar arbitrary value in my patch at
> https://savannah.gnu.org/bugs/?51200

I was thinking we'd just remove blocking writes to the pipe when we
initialized it, then check the error code when writing.  If we get
EAGAIN we know we ran out of room and we can fail.

-- 
Paul D. Smith <psmith@gnu.org>            Find some GNU Make tips at:
https://www.gnu.org                       http://make.mad-scientist.net
"Please remain calm...I may be mad, but I am a professional." --Mad
Scientist






reply via email to

[Prev in Thread] Current Thread [Next in Thread]