Re: the test suite fails

[Benno Schulenberg]

Jim Meyering wrote:
> Benno Schulenberg <address@hidden> wrote:
> > Trying to install parted-.1.8.7 from an overlay produces this:
>
> Thanks for the report.
> What is an "overlay"?

Something Gentoo-specific.

> Also, when a test fails, please rerun it like e.g.,
>
>   cd tests && ./t1000-basic.sh --debug --verbose

# cd /var/tmp/portage/sys-apps/parted-1.8.7/work/parted-1.8.7/tests
# ./t0000-basic.sh --debug --verbose
./t0000-basic.sh: line 29: /test-lib.sh: No such file or directory
#  ./t1000-mkpartfs.sh --debug --verbose
./t1000-mkpartfs.sh: line 22: /test-lib.sh: No such file or directory
#  ./t2000-mkfs.sh --debug --verbose
./t2000-mkfs.sh: line 22: /test-lib.sh: No such file or directory

It tries to source a file, but $srcdir is not defined.  Those lines should 
probably just read ". ./test-lib.sh" instead of ". $srcdir/test-lib.sh".
But after making that change the tests still fail:


# ./t0000-basic.sh --debug --verbose
* expecting success: dd if=/dev/zero of=$dev bs=$N count=1 2> /dev/null
*   ok 1: create the test file

* expecting success: parted -s $dev mklabel msdos > out 2>&1
*   ok 2: run parted -s FILE mklabel msdos

* expecting success: $compare out /dev/null
--- out 2007-05-16 14:47:00.000000000 +0000
+++ /dev/null   2005-05-14 16:37:31.000000000 +0000
@@ -1 +0,0 @@
-
\ No newline at end of file
* FAIL 3: expect no output
        $compare out /dev/null

* expecting success: dd if=/dev/zero of=$dev bs=$N count=1 2> /dev/null
*   ok 4: erase the left-over label

* expecting success: parted $dev mklabel msdos > out 2>&1
*   ok 5: run parted mklabel (without -s) on a blank disk

* expecting success: test "$uid" = 0 && : > exp || echo "$warning_msg" > exp
*   ok 6: create expected output file

* expecting success: $compare out exp 1>&2
--- out 2007-05-16 14:47:00.000000000 +0000
+++ exp 2007-05-16 14:47:00.000000000 +0000
@@ -1 +0,0 @@
-
\ No newline at end of file
* FAIL 7: check its "interactive" output
        $compare out exp 1>&2

* expecting success: printf "y\n\n" > in
*   ok 8: create interactive input

* expecting success: parted ---pretend-input-tty $dev mklabel msdos < in > o2 
2>&1
*   ok 9: rerun that same command, but now with a preexisting label

,,;s, $,," o2 > out: sed "s,on /.*/$dev,on DEVICE,;s,
*   ok 10: normalize the actual output

* expecting success: test $fail = 0
*   ok 11: create expected output file

* expecting success: $compare out exp
--- out 2007-05-16 14:47:00.000000000 +0000
+++ exp 2007-05-16 14:47:00.000000000 +0000
@@ -1,3 +1,3 @@
-Warning: The existing disk label on DEVICE will be destroyed and all data on 
this disk will be lost. Do you want to continue?
+Warning: The existing disk label on DEVICE will be destroyed and all data on 
this disk will be lost. Do you want to continue?
 Yes/No? y
 New disk label type?  [msdos]?
* FAIL 12: check its output -- slightly different here, due to prompts
        $compare out exp

* failed 3 among 12 test(s)



# ./t1000-mkpartfs.sh --debug --verbose
* expecting success: dd if=/dev/zero of=$dev bs=$N count=1 2> /dev/null
*   ok 1: create a file too small to hold a fat32 file system

* expecting success: parted -s $dev mklabel msdos > out 2>&1
*   ok 2: label the test disk

* expecting success: $compare out /dev/null
--- out 2007-05-16 14:47:32.000000000 +0000
+++ /dev/null   2005-05-14 16:37:31.000000000 +0000
@@ -1 +0,0 @@
-
\ No newline at end of file
* FAIL 3: expect no output
        $compare out /dev/null

* expecting failure: parted -s $dev mkpartfs primary fat32 0 1 > out 2>&1
*   ok 4: try/fail to create a file system in too small a space

* expecting success: echo "Error: Partition too big/small for a fat32 file 
system." > exp
*   ok 5: create expected output file

* expecting success: $compare out exp
--- out 2007-05-16 14:47:32.000000000 +0000
+++ exp 2007-05-16 14:47:32.000000000 +0000
@@ -1 +1 @@
-Error: Partition too big/small for a fat32 file system.
+Error: Partition too big/small for a fat32 file system.
* FAIL 6: check for expected failure diagnostic
        $compare out exp

* expecting success: rm $dev out
*   ok 7: clean up, preparing for next test

* expecting success: dd if=/dev/zero of=$dev bs=$N count=1 2> /dev/null
*   ok 8: create a file large enough to hold a fat32 file system

* expecting success: parted -s $dev mklabel msdos > out 2>&1
*   ok 9: label the test disk

* expecting success: $compare out /dev/null
--- out 2007-05-16 14:47:34.000000000 +0000
+++ /dev/null   2005-05-14 16:37:31.000000000 +0000
@@ -1 +0,0 @@
-
\ No newline at end of file
* FAIL 10: expect no output
        $compare out /dev/null

* expecting success: parted -s $dev mkpartfs primary fat32 1 40 > out 2>&1
*   ok 11: create an msdos file system

* expecting success: $compare out /dev/null
--- out 2007-05-16 14:47:34.000000000 +0000
+++ /dev/null   2005-05-14 16:37:31.000000000 +0000
@@ -1 +0,0 @@
-
\ No newline at end of file
* FAIL 12: expect no output
        $compare out /dev/null

* failed 4 among 12 test(s)



# ./t2000-mkfs.sh --debug --verbose
* expecting success: dd if=/dev/zero of=$dev bs=$N count=1 2> /dev/null
*   ok 1: create a file large enough to hold a fat32 file system

* expecting success: parted -s $dev mklabel msdos > out 2>&1
*   ok 2: label the test disk

* expecting success: $compare out /dev/null
--- out 2007-05-16 14:47:52.000000000 +0000
+++ /dev/null   2005-05-14 16:37:31.000000000 +0000
@@ -1 +0,0 @@
-
\ No newline at end of file
* FAIL 3: expect no output
        $compare out /dev/null

* expecting success: parted -s $dev mkpart primary 1 40 > out 2>&1
*   ok 4: create an partition

* expecting success: parted -s $dev mkfs 1 fat32 > out 2>&1
*   ok 5: create an msdos file system

* expecting success: $compare out /dev/null
--- out 2007-05-16 14:47:52.000000000 +0000
+++ /dev/null   2005-05-14 16:37:31.000000000 +0000
@@ -1 +0,0 @@
-
\ No newline at end of file
* FAIL 6: expect no output
        $compare out /dev/null

* failed 2 among 6 test(s)


Benno