Re: the test suite fails

[Jim Meyering]

Benno Schulenberg <address@hidden> wrote:
> Jim Meyering wrote:
>> Benno Schulenberg <address@hidden> wrote:
>> > Trying to install parted-.1.8.7 from an overlay produces this:
>>
>> Thanks for the report.
>> What is an "overlay"?
>
> Something Gentoo-specific.

Thanks, but that doesn't help me reproduce it, since
I don't have convenient access to a gentoo system.
But that's ok, as long as you're willing to help out.

>> Also, when a test fails, please rerun it like e.g.,
>>
>>   cd tests && ./t1000-basic.sh --debug --verbose
>
> # cd /var/tmp/portage/sys-apps/parted-1.8.7/work/parted-1.8.7/tests
> # ./t0000-basic.sh --debug --verbose
> ./t0000-basic.sh: line 29: /test-lib.sh: No such file or directory
> #  ./t1000-mkpartfs.sh --debug --verbose
> ./t1000-mkpartfs.sh: line 22: /test-lib.sh: No such file or directory
> #  ./t2000-mkfs.sh --debug --verbose
> ./t2000-mkfs.sh: line 22: /test-lib.sh: No such file or directory
>
> It tries to source a file, but $srcdir is not defined.  Those lines should
> probably just read ". ./test-lib.sh" instead of ". $srcdir/test-lib.sh".

That works for you, but would fail for someone doing a non-srcdir build.
It is fixed properly on the trunk, but I did that only recently,
and so those changes aren't in 1.8.7.

> But after making that change the tests still fail:
>
> # ./t0000-basic.sh --debug --verbose
> * expecting success: dd if=/dev/zero of=$dev bs=$N count=1 2> /dev/null
> *   ok 1: create the test file
>
> * expecting success: parted -s $dev mklabel msdos > out 2>&1
> *   ok 2: run parted -s FILE mklabel msdos
>
> * expecting success: $compare out /dev/null
> --- out 2007-05-16 14:47:00.000000000 +0000
> +++ /dev/null   2005-05-14 16:37:31.000000000 +0000
> @@ -1 +0,0 @@
> -
> \ No newline at end of file
> * FAIL 3: expect no output
>         $compare out /dev/null

Can you see why that's failing?
The preceding parted command is supposed to produce no output (i.e.
out is supposed to be an empty file), and comparing that to /dev/null
should succeed.

...
> * expecting success: $compare out exp
> --- out 2007-05-16 14:47:00.000000000 +0000
> +++ exp 2007-05-16 14:47:00.000000000 +0000
> @@ -1,3 +1,3 @@
> -Warning: The existing disk label on DEVICE will be destroyed and all data on 
> this disk will be lost. Do you want to continue?
> +Warning: The existing disk label on DEVICE will be destroyed and all data on 
> this disk will be lost. Do you want to continue?

The two preceding lines look identical to me, but diff found a difference.
Is there a difference in the line-ending byte?

>  Yes/No? y
>  New disk label type?  [msdos]?
> * FAIL 12: check its output -- slightly different here, due to prompts
...

All of the failures match one of the two preceding cases,
so once you solve them, we should be done.