[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH parted 3/3] dasd: fix memleak in dasd_free
From: |
Jim Meyering |
Subject: |
Re: [PATCH parted 3/3] dasd: fix memleak in dasd_free |
Date: |
Wed, 09 Dec 2009 20:36:19 +0100 |
Hans de Goede wrote:
> * libparted/labels/dasd.c(dasd_free): free disk_specific data.
> ---
> libparted/labels/dasd.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/libparted/labels/dasd.c b/libparted/labels/dasd.c
> index dd492f2..57612a3 100644
> --- a/libparted/labels/dasd.c
> +++ b/libparted/labels/dasd.c
> @@ -204,9 +204,13 @@ dasd_duplicate (const PedDisk* disk)
> static void
> dasd_free (PedDisk* disk)
> {
> + DasdDiskSpecific *disk_specific;
> +
> PED_ASSERT(disk != NULL, return);
>
> + disk_specific = disk->disk_specific;
> _ped_disk_free(disk);
> + free(disk_specific);
> }
Thanks! I've tweaked it slightly.
This is equivalent:
>From e1108e6e73b6800b68dafe61932fb683a88e1219 Mon Sep 17 00:00:00 2001
From: Hans de Goede <address@hidden>
Date: Wed, 9 Dec 2009 15:38:02 +0100
Subject: [PATCH] dasd: fix leak in dasd_free
* libparted/labels/dasd.c (dasd_free): Free disk_specific data.
---
libparted/labels/dasd.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/libparted/labels/dasd.c b/libparted/labels/dasd.c
index 59f1594..9169883 100644
--- a/libparted/labels/dasd.c
+++ b/libparted/labels/dasd.c
@@ -185,7 +185,7 @@ static void
dasd_free (PedDisk* disk)
{
PED_ASSERT(disk != NULL, return);
-
+ free(disk->disk_specific);
_ped_disk_free(disk);
}
--
1.6.6.rc1.319.g9b57d