bug-parted
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] tests: fix a bug in wait_for_dev_to_disappear_ helper function


From: Jim Meyering
Subject: [PATCH] tests: fix a bug in wait_for_dev_to_disappear_ helper function
Date: Thu, 05 Jan 2012 18:28:36 +0100

Ouch.  I was surprised to see the t9030-align-check.sh test
appear to hang on a Debian unstable system.  The loop termination
expression was always failing due to a shell syntax error.

>From e54f1da5bd2c379d8d2e4e7d5bb086b4947d4591 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Thu, 5 Jan 2012 18:24:41 +0100
Subject: [PATCH] tests: fix a bug in wait_for_dev_to_disappear_ helper
 function

* tests/t-lib-helpers.sh (wait_for_dev_to_disappear_): Correct
typo: missing expr in subshell.
---
 tests/t-lib-helpers.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tests/t-lib-helpers.sh b/tests/t-lib-helpers.sh
index 3c41e7b..4b3c122 100644
--- a/tests/t-lib-helpers.sh
+++ b/tests/t-lib-helpers.sh
@@ -388,7 +388,7 @@ wait_for_dev_to_disappear_()
   while :; do
     ls "$file" > /dev/null 2>&1 || return 0
     sleep .1 2>/dev/null || { sleep 1; incr=10; }
-    i=$(expr $i + $incr); test $i -ge $($n_sec \* 10) && break
+    i=$(expr $i + $incr); test $i -ge $(expr $n_sec \* 10) && break
   done
   return 1
 }
--
1.7.8.2.334.gd4e886



reply via email to

[Prev in Thread] Current Thread [Next in Thread]