Re: Build failure caused by out of date gnulib

[Andreas Grünbacher]

Hello Collin,

Am So., 25. Feb. 2024 um 23:09 Uhr schrieb Collin Funk <collin.funk1@gmail.com>:
> On 2/25/24 1:22 PM, Collin Funk wrote:
>  > I've attached a patch that does this.
>
> Assuming that there are no problems with that update this patch should
> be applied too. I've added 'subdir-objects' to AM_INIT_AUTOMAKE to
> silence these warnings:
>
> lib/gnulib.mk:103: warning: source file 
> 'malloc/scratch_buffer_grow_preserve.c' is in a subdirectory,
> lib/gnulib.mk:103: but option 'subdir-objects' is disabled
> lib/Makefile.am:14:   'lib/gnulib.mk' included from here
> lib/gnulib.mk:103: warning: source file 
> 'malloc/scratch_buffer_set_array_size.c' is in a subdirectory,
> lib/gnulib.mk:103: but option 'subdir-objects' is disabled
> lib/Makefile.am:14:   'lib/gnulib.mk' included from here
> lib/gnulib.mk:103: warning: source file 'glthread/lock.c' is in a 
> subdirectory,
> lib/gnulib.mk:103: but option 'subdir-objects' is disabled
> lib/Makefile.am:14:   'lib/gnulib.mk' included from here
> lib/gnulib.mk:103: warning: source file 'glthread/threadlib.c' is in a 
> subdirectory,
> lib/gnulib.mk:103: but option 'subdir-objects' is disabled
> lib/Makefile.am:14:   'lib/gnulib.mk' included from here
> lib/gnulib.mk:3223: warning: source file 'unictype/ctype_print.c' is in a 
> subdirectory,
> lib/gnulib.mk:3223: but option 'subdir-objects' is disabled
> lib/Makefile.am:14:   'lib/gnulib.mk' included from here
>
> Then changed calls to hash_delete to use hash_remove instead. The
> first is marked for removal by this commit:
>
> https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=342e7423fd65e96f83299494d69ddf03e171413e
>
> There are also some warnings about obsolete Autoconf macros. I've left
> the unchanged as I am unsure if they will break builds for older
> versions. I am using version 2.71 if it matters.
>
> Let me know if I missed anything.

looking good as well. I've applied this, too.

Thanks,
Andreas