Re: patch-2.7.6.200-be8b on Haiku

[Bruno Haible]

Eli Schwartz wrote:
> Bisected, and landed on:
> 
> 
> 043355371a76de8ea7d06f79a69fde905af7cc45 is the first bad commit
> commit 043355371a76de8ea7d06f79a69fde905af7cc45
> Author:     Paul Eggert <eggert@cs.ucla.edu>
> AuthorDate: Fri Sep 6 22:32:54 2024
> Commit:     Paul Eggert <eggert@cs.ucla.edu>
> CommitDate: Mon Sep 16 01:50:38 2024
> 
>     X == -1 → X < 0

Oh, I see. On Haiku, system-defined errno values are not positive (as
demanded by POSIX), but negative [1]. Since there's no chance that this
will change (because changing errno values would mean that all programs
need to be recompiled), we need to bite the sour apple and revert to
== -1 for errno values.

With the attached patch, the tests concat-git-diff and remember-backup-files
now pass. The only remaining test failure is preserve-mode-and-timestamp,
for which we have an explanation.

Bruno

[1] https://www.gnu.org/software/gnulib/manual/html_node/errno_002eh.html

0001-Fix-two-test-failures-on-Haiku.patch
Description: Text Data