bug#35997: Sed 4.7 and one self test failure

[Assaf Gordon]

Hello  Jeff,

On Wed, May 29, 2019 at 07:29:01PM -0400, Jeffrey Walton wrote:
> 
> I'm working on Fedora 29 x86_64, fully patched. I'm catching one self
> test failure in Sed 4.7:
> 
> FAIL: testsuite/inplace-selinux.sh

Thanks for the report.

This likely happened because sed was built without SELinux support.
Do you have the "libseliunx-devel" pacakge installed on your machine?

One quick way to find if sed was compiled with SELinux is by checking
the required shared-objects:

    $ ldd sed/sed
    linux-vdso.so.1 (0x00007ffc4c1ba000)
    libselinux.so.1 => /lib64/libselinux.so.1 (0x00007fa966ccd000)
    libc.so.6 => /lib64/libc.so.6 (0x00007fa966b07000)
    libpcre2-8.so.0 => /lib64/libpcre2-8.so.0 (0x00007fa966a78000)
    libdl.so.2 => /lib64/libdl.so.2 (0x00007fa966a72000)
    /lib64/ld-linux-x86-64.so.2 (0x00007fa966d07000)
    libpthread.so.0 => /lib64/libpthread.so.0 (0x00007fa966a50000)

If there is no "libselinux.so" listed - SED will not support SELinux
context when modifing files in-place.

(Also compare your custom-built binary to the system's /bin/sed binary -
the native one was likely compiled with selinux.)

But as a side-note, we should improve the "inplace-selinux.sh" test to
prevent such false-positives (just skip the test if no SELinux support
either in the system or in the sed binary).

regards,
 -assaf