Re: maint: Update library names used by Gnulib.

[Pavel Raiskup]

On čtvrtek 12. září 2024 4:10:54, SELČ Collin Funk wrote:
> Hi Paul,
> 
> Collin Funk <collin.funk1@gmail.com> writes:
> 
> > Some library names in Gnulib changed on or around 2023-01-07 (see NEWS).
> > This patch fixes variables in tar's Makefile's.
> 
> I think this patch might have gotten lost like my bug-gzip one.
> 
> I've attached a fixed version that doesn't incorrectly remove
> $(LIB_ACL). Could you please check it?
> 
> Also, building GNU tar fails on my system using xgettext 0.22.5 from
> this error:
> 
> /usr/bin/xgettext: Non-ASCII comment at or before src/checkpoint.c:251.
>                    Please specify the source encoding through --from-code.
> make[3]: *** [Makefile:307: tar.pot-update] Error 1
> make[3]: Leaving directory '/home/collin/.local/src/tar/po'
> make[2]: *** [Makefile:375: tar.pot] Error 2
> make[2]: Leaving directory '/home/collin/.local/src/tar/po'
> make[1]: *** [Makefile:1936: all-recursive] Error 1
> make[1]: Leaving directory '/home/collin/.local/src/tar'
> make: *** [Makefile:1876: all] Error 2
> 
> I think my second patch should fix this by using the '--from-code=UTF-8'
> argument.

Thank you for the patches, Collin!

I'd wish these contributions got much higher priority upstream, and were
merged ASAP.  Not-fixing makes the integration with distributions
complicated, e.g., the "git head" CI "attempt" for Fedora/RHEL 
got broken [1], and it forces me to do downstream-only patches like [2]:

[1] https://github.com/praiskup/tar/blob/ci/README.md
[2] 
https://github.com/praiskup/tar/commit/d106582b74e3bfbbc096a615cd2b7c4a10e2bcaa

Pavel

> 
> Collin
> 
>