[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] [PATCH v4] (resend) Add --use-askpass=COMMAND support
From: |
Tim Ruehsen |
Subject: |
Re: [Bug-wget] [PATCH v4] (resend) Add --use-askpass=COMMAND support |
Date: |
Wed, 07 Sep 2016 10:48:15 +0200 |
User-agent: |
KMail/5.2.3 (Linux/4.7.0-1-amd64; KDE/5.25.0; x86_64; ; ) |
Hi Liam,
I made a mistake and accidentally pushed your v4 patch to master a few days
ago.
Here is a fix for several issues (warnings, C89 incompatibility, using strpbrk
to find end-of-line, append newline to error messages).
I removed your extra checks, so that a user can just work with executables in
the PATH (posix_spawnp searches the path):
wget --use-askpass=ssh-askpass <URL>
If the executable does not exists (or something goes wrong when executing),
wget will error & stop at that point anyways.
Here is the fix, WDYT ?
Regards, Tim
0001-Code-cleanup-for-use-askpass.patch
Description: Text Data
signature.asc
Description: This is a digitally signed message part.