Re: [Bug-wget] [PATCH 23/25] New: --trust-server-names saves Metalink/HTTP xml files using the "name" field

[Giuseppe Scrivano]

Hi Matthew,

Matthew White <address@hidden> writes:

> [Coverity Scan is ok, make syntax-check is ok, make check-valgrind is ok, 
> contrib/check-hard is ok]
>
> This allows to use the value of the "name" field, part of a Metalink/HTTP 
> application/metalink4+xml Link, as file name for the Metalink file to be 
> saved.
>
> This conforms to the RFC6249 standard:
> https://tools.ietf.org/html/rfc6249#section-4
>
> e.g.
> $ wget --metalink-over-http --metalink-index=inf --trust-server-names <url of 
> a Metalink/HTTP header with application/metlaink4+xml links>
>
>   Link: <http://example.com/file.ext.meta4>; rel=describedby; 
> type="application/metalink4+xml"; name="newname.meta4"
>
>   When --trust-server-names is used, file.ext.meta4 is saved as newname.meta4.
>
> Regards,
> Matthew
>
> -- 
> Matthew White <address@hidden>
>
> From 30b09eb7dbfbb9423efb6bd4009203f887d90786 Mon Sep 17 00:00:00 2001
> From: Matthew White <address@hidden>
> Date: Tue, 30 Aug 2016 09:26:41 +0200
> Subject: [PATCH 23/25] New: --trust-server-names saves Metalink/HTTP xml files
>  using the "name" field
>
> * src/metalink.c (retrieve_from_metalink): If opt.trustservernames is
>   true, use the basename of the metaurl's name to save the xml file
> * doc/metalink-standard.txt: Update doc. With --trust-server-names any
>   Metalink/HTTP Link application/metalink4+xml file is saved using the
>   basename of the "name" field, if any. Update Metalink/HTTP examples
> * testenv/Makefile.am: Add new file
> * testenv/Test-metalink-http-xml-trust-name.py: New file. Metalink/HTTP
>   automated Metalink/XML, save xml files using the "name" field tests
> ---
>  doc/metalink-standard.txt                    |  10 +
>  src/metalink.c                               |   2 +-
>  testenv/Makefile.am                          |   1 +
>  testenv/Test-metalink-http-xml-trust-name.py | 273 
> +++++++++++++++++++++++++++
>  4 files changed, 285 insertions(+), 1 deletion(-)
>  create mode 100755 testenv/Test-metalink-http-xml-trust-name.py

ACK

Giuseppe