Re: [Bug-wget] bug #48811: netrc password wins over interactive --ask-password

[Darshit Shah]

This patch looks good. However, if we are touching this part of the 
code, I would like to take the opportunity to clean it up as well.

From a brief glance it looks like the code for check for username and 
password can be abstracted into its own function. This way we can 
improve readability and reduce redundant code.

Could you please refactor this so that both http and ftp use the same 
function to read the username and password? 

* Wajda, Piotr <address@hidden> [160916 23:47]:
> I've tried to tackle another bug. I've moved reading from .netrc file 
> to the end, when no user and no passwd is defined (for both http and 
> ftp).
>
> Please review.
>
> Thanks
> Piotr

-- Thanking You,
Darshit Shah
PGP Fingerprint: 7845 120B 07CB D8D6 ECE5 FF2B 2A17 43ED A91A 35B6

signature.asc
Description: PGP signature